[webkit-reviews] review granted: [Bug 122520] WebProcess crash on SAP WebCycle web app : [Attachment 213714] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 122520: WebProcess crash on SAP WebCycle web app
https://bugs.webkit.org/show_bug.cgi?id=122520

Attachment 213714: Patch
https://bugs.webkit.org/attachment.cgi?id=213714&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213714&action=review


> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:509
> +    NSEvent *event = [NSEvent otherEventWithType:NSApplicationDefined
> +					   location:NSMakePoint(0, 0)
> +				      modifierFlags:0
> +					  timestamp:0.0
> +					windowNumber:0
> +					    context:nil
> +					    subtype: 0
> +					      data1:0
> +					      data2:0];

Would be nice to format this in a less high-maintenance way without the lined
up colons. Also, subtype has a space after it.

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:224
> +    ASSERT([NSApp isRunning]);
> +    [NSApp stop:nil];
> +    NSEvent *event = [NSEvent otherEventWithType:NSApplicationDefined
> +					   location:NSMakePoint(0, 0)
> +				      modifierFlags:0
> +					  timestamp:0.0
> +					windowNumber:0
> +					    context:nil
> +					    subtype: 0
> +					      data1:0
> +					      data2:0];
> +    [NSApp postEvent:event atStart:true];

Should share this code with PluginProcess::stopRunLoop.