[webkit-reviews] review requested: [Bug 81123] cue.text fails for some track element cues : [Attachment 213710] Fix buffer logic

[bugzilla-daemon at webkit.org]

Brendan Long <b.long at cablelabs.com> has asked  for review:
Bug 81123: cue.text fails for some track element cues
https://bugs.webkit.org/show_bug.cgi?id=81123

Attachment 213710: Fix buffer logic
https://bugs.webkit.org/attachment.cgi?id=213710&action=review

------- Additional Comments from Brendan Long <b.long at cablelabs.com>
My original version of this patch had a lot of little problems.
deprecatedDidReceiveCachedResource() is definitely needed (although maybe it
can be replaced with dataReceived()?). With that in place,
m_cueParser->fileFinished() needs to go in notifyFinished() (so it doesn't get
called every time we get data). I also added m_finished with an ASSERT so this
doesn't bite anyone else in the future. I also messed up the handling of line
breaks: According to the spec, any of \r, \n, and \r\n are all allowed. The
current patch should fix all of these things, and the test passes on WebKitGTK
(I'm building a different patch on my Mac, but I'll go to that if this fails on
EWS again).