[webkit-reviews] review granted: [Bug 122486] Video -> pixel buffer output should not manage color spaces : [Attachment 213704] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 122486: Video -> pixel buffer output should not manage color spaces
https://bugs.webkit.org/show_bug.cgi?id=122486

Attachment 213704: Patch
https://bugs.webkit.org/attachment.cgi?id=213704&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213704&action=review


Indeed, hopefully this will all get cleaned up in the near future. r+ if one of
the media folks agree for now.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:866
> +    CGImageRef rawImage = [m_imageGenerator.get()
copyCGImageAtTime:CMTimeMakeWithSeconds(time, 600) actualTime:nil error:nil];

Vaguely intrigued why this isn't a retainptr too but there's really no reason
for it to be!