[webkit-reviews] review granted: [Bug 122495] [Mac] WebNetscapePluginView should no longer use deleteAllValues : [Attachment 213673] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 122495: [Mac] WebNetscapePluginView should no longer use deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122495

Attachment 213673: Patch
https://bugs.webkit.org/attachment.cgi?id=213673&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213673&action=review


> Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:711
> +    for (auto& it: *timers)
> +	   it.value->stop();

Can use timers->values() here to avoid it.value.

> Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:725
> +    for (auto& it: *timers) {

Same thing here.

> Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:2165
> +    while (timerID == 0 || HashTraits<uint32>::isDeletedValue(timerID) ||
*(slot = &timers->add(timerID, nullptr).iterator->value));

I think we have HashSet::isGoodValue that you can use here.