[webkit-reviews] review granted: [Bug 122480] Consolidate findString functions : [Attachment 213659] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 8 02:18:57 PDT 2013


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 122480: Consolidate findString functions
https://bugs.webkit.org/show_bug.cgi?id=122480

Attachment 213659: Patch
https://bugs.webkit.org/attachment.cgi?id=213659&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213659&action=review


> Source/WebKit/efl/ewk/ewk_frame.cpp:501
> +    WebCore::FindOptions options = (caseSensitive ? 0 :
WebCore::CaseInsensitive) | (forward ? 0 : WebCore::Backwards) | (shouldWrap ?
WebCore::WrapAround : 0) | WebCore::StartInSelection;

It’s wrap, not shouldWrap, in this function.


More information about the webkit-reviews mailing list