[webkit-reviews] review requested: [Bug 118363] GTK plugin widgets are not shown or hidden correctly : [Attachment 213670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 8 00:24:55 PDT 2013


Alberto Garcia <berto at igalia.com> has asked  for review:
Bug 118363: GTK plugin widgets are not shown or hidden correctly
https://bugs.webkit.org/show_bug.cgi?id=118363

Attachment 213670: Patch
https://bugs.webkit.org/attachment.cgi?id=213670&action=review

------- Additional Comments from Alberto Garcia <berto at igalia.com>
Sorry for having taken so long to look into this.

The problem is that the web view is not propagating the GTK
size_allocate call to its children, so even if any of them needs it
(in this case: a new label appears and needs to compute its size) it
will not get its allocation.

It works if you resize the window because changing the size of the
frame will force a new allocation (via GtkPluginWidget::frameRectsChanged).


More information about the webkit-reviews mailing list