[webkit-reviews] review granted: [Bug 122492] [Mac] Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues : [Attachment 213663] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 8 00:01:46 PDT 2013


Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 122492: [Mac] Change NetscapePluginInstanceProxy::m_replies to use
unique_ptr instead of deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122492

Attachment 213663: Patch
https://bugs.webkit.org/attachment.cgi?id=213663&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213663&action=review


r=me

> Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:254
> -	   m_replies.set(requestID, reply);
> +	   m_replies.add(requestID, std::move(reply));

Nice.


More information about the webkit-reviews mailing list