[webkit-reviews] review granted: [Bug 122483] EventDispatchBehavior is unnecessary : [Attachment 213648] Cleanup

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 122483: EventDispatchBehavior is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=122483

Attachment 213648: Cleanup
https://bugs.webkit.org/attachment.cgi?id=213648&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213648&action=review


r=me.

> Source/WebCore/dom/EventRetargeter.cpp:38
> +static inline bool shouldEventCrossShadowBoundary(Event* event, ShadowRoot*
shadowRoot, EventTarget* target)

All three parameters should be references.

> Source/WebCore/dom/EventRetargeter.cpp:48
> +	       if (element->isMediaElement() && shadowRoot &&
shadowRoot->hostElement() == element)

'shadowRoot' is already null-checked by the caller.

> Source/WebCore/dom/EventRetargeter.cpp:58
> +    bool tagetIsInShadowRoot = targetNode &&
targetNode->treeScope().rootNode() == shadowRoot;

Typo, taget -> target.