[webkit-reviews] review granted: [Bug 122477] Make buildRelatedNodeMap and findRelatedNode static to EventRetargeter.cpp : [Attachment 213637] Minor bug fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 18:33:15 PDT 2013


Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 122477: Make buildRelatedNodeMap and findRelatedNode static to
EventRetargeter.cpp
https://bugs.webkit.org/show_bug.cgi?id=122477

Attachment 213637: Minor bug fix
https://bugs.webkit.org/attachment.cgi?id=213637&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=213637&action=review


> Source/WebCore/dom/EventRetargeter.cpp:184
> +static void buildRelatedNodeMap(const Node* relatedNode, HashMap<TreeScope*,
Node*>& relatedNodeMap)

I wish these had more descriptive names. Related to what and how? Same applies
to variable names in this code.

> Source/WebCore/dom/EventRetargeter.h:65
>      typedef Vector<RefPtr<Node> > AdjustedNodes;

Would be nice to remove this opaque typedef too.


More information about the webkit-reviews mailing list