[webkit-reviews] review requested: [Bug 81123] cue.text fails for some track element cues : [Attachment 213632] Buffer data in WebVTTParser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 17:48:17 PDT 2013


Brendan Long <b.long at cablelabs.com> has asked  for review:
Bug 81123: cue.text fails for some track element cues
https://bugs.webkit.org/show_bug.cgi?id=81123

Attachment 213632: Buffer data in WebVTTParser
https://bugs.webkit.org/attachment.cgi?id=213632&action=review

------- Additional Comments from Brendan Long <b.long at cablelabs.com>
The running theme in a lot of bug reports (see also #95691 and possibly #97097)
is that we cut off parsing in the wrong place. This patch adds a buffer. For
some reason the test gets a cross-origin error on WebKitGTK though, and I'm not
entirely sure if just removing deprecatedDidReceiveCachedResource is correct
(although it seems to work, and the FIXME comment suggests that that's what we
should do).


More information about the webkit-reviews mailing list