[webkit-reviews] review granted: [Bug 122468] Track controls show metadata and chapter tracks : [Attachment 213619] Only show captions, descriptions and subtitles in the track menu

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brendan Long <b.long at cablelabs.com>'s
request for review:
Bug 122468: Track controls show metadata and chapter tracks
https://bugs.webkit.org/show_bug.cgi?id=122468

Attachment 213619: Only show captions, descriptions and subtitles in the track
menu
https://bugs.webkit.org/attachment.cgi?id=213619&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213619&action=review


The test is failing on the bot; you will need to figure out why before landing.


> Source/WebCore/page/CaptionUserPreferences.cpp:183
> +	   RefPtr<TextTrack> track = trackList->item(i);

It’s not necessary to churn the reference counts of these tracks by putting
them in a RefPtr. A raw pointer is a better choice. The best choice is to just
use "auto".