[webkit-reviews] review granted: [Bug 122467] Modify WTF and JavascriptCore makefiles for 64bit build : [Attachment 213618] patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 122467: Modify WTF and JavascriptCore makefiles for 64bit build
https://bugs.webkit.org/show_bug.cgi?id=122467

Attachment 213618: patch
https://bugs.webkit.org/attachment.cgi?id=213618&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213618&action=review


r=me with one suggestion before you land.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.make:36
> +    set Path=%PATH%;$(SRCROOT)\%ProgramFilesAAS%

It seems like this %PATH% will contain the 32-bit path from line 12/14 above.
Should we use a separate value here? Or maybe hold onto the original PATH
(pre-changing in 12/14) with a different name, like "set OrigPath=%PATH%", then
here do "Set Path=%OrigPath%;$(SRCROOT)...etc."

> Source/WTF/WTF.vcxproj/WTF.make:26
> +    set Path=%PATH%;$(SRCROOT)\%ProgramFilesAAS%

Ditto regarding path from above. Might want to retain original path in a
separate variable, then use it here so we don't get the 32-bit path before our
64-bit stuff.