[webkit-reviews] review granted: [Bug 122465] Always force discrete mode when running layout tests : [Attachment 213615] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 7 13:21:53 PDT 2013
Tim Horton <thorton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 122465: Always force discrete mode when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=122465
Attachment 213615: Patch
https://bugs.webkit.org/attachment.cgi?id=213615&action=review
------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213615&action=review
> Tools/DumpRenderTree/mac/LayoutTestHelper.m:173
> + while ((option = getopt_long(argc, (char * const *)argv, "", options,
NULL)) != -1) {
not sure those stars are right
> Tools/DumpRenderTree/mac/LayoutTestHelper.m:175
> + case '?': // unknown or ambiguous option
case shouldn’t be indented
More information about the webkit-reviews
mailing list