[webkit-reviews] review denied: [Bug 118448] [WK2][Soup] Implement NetworkResourceLoader::didReceiveData : [Attachment 209651] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 118448: [WK2][Soup] Implement NetworkResourceLoader::didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=118448

Attachment 209651: Patch
https://bugs.webkit.org/attachment.cgi?id=209651&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
This patch cannot possibly be right any longer.  NetworkResourceLoader doesn't
message the WebProcess; AsynchronousNetworkLoaderClient and
SynchronousNetworkLoaderClient do.

Sync XHRs cannot possibly work with this patch, for example.

Note that (A)SynchronousNetworkLoaderClient do not have didReceiveData calls,
but only have didReceiveBuffer.

Right now, on non-Mac platforms, they always perform a copy out of the buffer. 
This will not be true in the future.  And I don't think we should make the
mistake of adding a didReceiveData now just to cover for a networking
implementation that doesn't support a buffer callback.