[webkit-reviews] review denied: [Bug 99200] Add support for blendmode to Core Animation layer : [Attachment 203342] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Mihai Tica
<mitica at adobe.com>'s request for review:
Bug 99200: Add support for blendmode to Core Animation layer
https://bugs.webkit.org/show_bug.cgi?id=99200

Attachment 203342: Patch
https://bugs.webkit.org/attachment.cgi?id=203342&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203342&action=review


r-. We have to be able to do this without CIFilters.

> Source/WebCore/ChangeLog:3
> +	   Rebasing patch.

Not a useful change log comment.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:104
> +    virtual void setBlendMode(BlendMode);

OVERRIDE

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:792
> +    [m_layer.get() setCompositingFilter:filter];

We can't use CI filters without extra work, because on Mavericks it will kick
the WebProcess out of WindowServer-hosted compositing, and we need to add code
to deal with the switch to fix plug-ins etc.