[webkit-reviews] review denied: [Bug 122345] [iOS] Upstream support for -webkit-video-playable-inline/webkit-playsinline : [Attachment 213396] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 122345: [iOS] Upstream support for
-webkit-video-playable-inline/webkit-playsinline
https://bugs.webkit.org/show_bug.cgi?id=122345

Attachment 213396: Patch
https://bugs.webkit.org/attachment.cgi?id=213396&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213396&action=review


I don't see any reason for this to iOS specific.

> Source/WebCore/css/MediaFeatureNames.h:34
> +#if PLATFORM(IOS)

This should be ENABLE(...)

> Source/WebCore/css/MediaFeatureNames.h:35
> +#define IOS_VIDEO_PLAYABLE_INLINE(macro) macro(video_playable_inline,
"-webkit-video-playable-inline")

This should not have an iOS prefix.