[webkit-reviews] review denied: [Bug 33950] contentEditable with "position:relative" paragraphs is buggy : [Attachment 213574] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 11:01:52 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has denied Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 33950: contentEditable with "position:relative" paragraphs is buggy
https://bugs.webkit.org/show_bug.cgi?id=33950

Attachment 213574: Patch
https://bugs.webkit.org/attachment.cgi?id=213574&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213574&action=review


> Source/WebCore/editing/htmlediting.cpp:-420
> -    if (renderer->style()->position() != StaticPosition)
> -	   return true;

There are other position values such as absolute and fixed.
I don't think we want the same behavior as relative for those two values at
least.
At minimum, we need a test case. r- because of this.


More information about the webkit-reviews mailing list