[webkit-reviews] review granted: [Bug 122289] Transition stack check JITStubs to CCallHelper functions : [Attachment 213538] Updated patch addressing review comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 7 10:32:47 PDT 2013
Filip Pizlo <fpizlo at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 122289: Transition stack check JITStubs to CCallHelper functions
https://bugs.webkit.org/show_bug.cgi?id=122289
Attachment 213538: Updated patch addressing review comments
https://bugs.webkit.org/attachment.cgi?id=213538&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213538&action=review
r=me, but don't use "B" for CodeBlock*.
> Source/JavaScriptCore/jit/JITOperations.h:54
> + B: CodeBlock*
I've been moving towards having new "types" use multi-character names. The
convention is that it's always first letter capitalized, all other letters
lower case. I think that "Cb" would be intuitive enough.
More information about the webkit-reviews
mailing list