[webkit-reviews] review requested: [Bug 121940] [MediaStream API] update MediaStreamTrack object to match spec : [Attachment 213603] Updated patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has asked  for review:
Bug 121940: [MediaStream API] update MediaStreamTrack object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121940

Attachment 213603: Updated patch
https://bugs.webkit.org/attachment.cgi?id=213603&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
(In reply to comment #22)
> (From update of attachment 213600 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=213600&action=review
> 
> Here are the few issues I found when trying to build this patch on GTK
(without --media-stream)
> 
> > Source/WebCore/GNUmakefile.list.am:473
> > +	DerivedSources/WebCore/JSMediaSourceStatesCustom.cpp \
> 
Fixed.

> That path is incorrect and the file should be listed in webcore_sources
> 
> > Source/WebCore/GNUmakefile.list.am:482
> > +	DerivedSources/WebCore/JSMediaStreamCapabilitiesCustom.cpp \
> 
> Ditto
> 
Fixed.

> > Source/WebCore/GNUmakefile.list.am:5372
> > +	Source/WebCore/platform/mediastream/MediaStreamAudioSource.cpp \
> > +	Source/WebCore/platform/mediastream/MediaStreamAudioSource.h \
> 
> The files are in Modules/webaudio
> 
Fixed.

> > Source/WebCore/bindings/js/JSMediaStreamCapabilitiesCustom.cpp:51
> > +#endif // ENABLE(MEDIA_STREAM)
> 
> Misplaced #endif

Fixed.

Thanks!