[webkit-reviews] review denied: [Bug 122440] JavaScriptCore fails to build : [Attachment 213570] Proposed patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Rob Plociennik
<r.plociennik at samsung.com>'s request for review:
Bug 122440: JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122440

Attachment 213570: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=213570&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213570&action=review


> Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp:186
> +    ASSERT(!callFrame->codeBlock());
> +    ASSERT(!callFrame->codeBlock());

These asserts are meaningless without the line and column checks.  But you are
right that the line and column checks are not valid.  Please remove the 2
asserts completely.