[webkit-reviews] review granted: [Bug 122433] Factor text paint style computation out from InlineTextBox : [Attachment 213547] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 122433: Factor text paint style computation out from InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=122433

Attachment 213547: patch
https://bugs.webkit.org/attachment.cgi?id=213547&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213547&action=review


> Source/WebCore/rendering/TextPaintStyle.cpp:38
> +TextPaintStyle::TextPaintStyle()

I would zero-initialize the stroke width here for good measure.

> Source/WebCore/rendering/TextPaintStyle.h:54
> +void updateGraphicsContext(GraphicsContext*, const TextPaintStyle&,
StrokeColorType = UseNormalStrokeColor);

This should take a GraphicsContext&.