[webkit-reviews] review granted: [Bug 122432] Improve HashMap::add comment and other similar comments : [Attachment 213542] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 6 17:35:30 PDT 2013
Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 122432: Improve HashMap::add comment and other similar comments
https://bugs.webkit.org/show_bug.cgi?id=122432
Attachment 213542: Patch
https://bugs.webkit.org/attachment.cgi?id=213542&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213542&action=review
r=me with some suggestions from a non-native speaker:
> Source/WTF/wtf/HashCountedSet.h:60
> + // Increases the count if an equal value is already present.
Increases -> Increments
> Source/WTF/wtf/HashCountedSet.h:62
> + // and an isNewEntry bool that indicates if it is a new or existing
entry.
I'd say "indicates whether" rather than "indicates if"
> Source/WTF/wtf/HashCountedSet.h:65
> + // Reduces the count of the value, and removes it if count goes down
to zero.
Reduces -> Decrements
More information about the webkit-reviews
mailing list