[webkit-reviews] review granted: [Bug 122421] Clean up ContentData : [Attachment 213521] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 6 13:00:24 PDT 2013


Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 122421: Clean up ContentData
https://bugs.webkit.org/show_bug.cgi?id=122421

Attachment 213521: Patch
https://bugs.webkit.org/attachment.cgi?id=213521&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213521&action=review


> Source/WebCore/rendering/style/ContentData.h:50
> +    virtual std::unique_ptr<ContentData> clone() const;

override

> Source/WebCore/rendering/style/ContentData.h:65
> +    ImageContentData(PassRefPtr<StyleImage> image)

explicit

> Source/WebCore/rendering/style/ContentData.h:97
> +    TextContentData(const String& text)

explicit

> Source/WebCore/rendering/style/ContentData.h:123
> +    CounterContentData(std::unique_ptr<CounterContent> counter)

explicit

> Source/WebCore/rendering/style/ContentData.h:153
> +    QuoteContentData(QuoteType quote)

explicit


More information about the webkit-reviews mailing list