[webkit-reviews] review granted: [Bug 122410] Don't try to dispatch resize events for SVG images : [Attachment 213509] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 6 09:33:38 PDT 2013


Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 122410: Don't try to dispatch resize events for SVG images
https://bugs.webkit.org/show_bug.cgi?id=122410

Attachment 213509: patch
https://bugs.webkit.org/attachment.cgi?id=213509&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213509&action=review


r=me if you add a null check for page or explain why it's not needed

> Source/WebCore/page/FrameView.cpp:2773
> +    if (frame().page()->chrome().client().isSVGImageChromeClient())
> +	   return;

What guarantees that page is non-null?


More information about the webkit-reviews mailing list