[webkit-reviews] review granted: [Bug 122024] Compress DFG stack layout : [Attachment 213455] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 122024: Compress DFG stack layout
https://bugs.webkit.org/show_bug.cgi?id=122024

Attachment 213455: the patch
https://bugs.webkit.org/attachment.cgi?id=213455&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213455&action=review


>> Source/JavaScriptCore/bytecode/CodeOrigin.h:101
>> +	int stackOffset : 30;
> 
> Please declare integral type bitfields with either signed or unsigned. 
[runtime/bitfields] [5]

bring back the signed - this rule is to deal with various compiler issues we've
run into in the past (msvc mostly)