[webkit-reviews] review granted: [Bug 122322] MediaStreamTrack can't be FINAL : [Attachment 213343] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 4 17:44:40 PDT 2013


Darin Adler <darin at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 122322: MediaStreamTrack can't be FINAL
https://bugs.webkit.org/show_bug.cgi?id=122322

Attachment 213343: patch
https://bugs.webkit.org/attachment.cgi?id=213343&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
How did this even compile?

Can any of the virtual functions in MediaStreamTrack be FINAL? If the entire
class isn’t FINAL, it then becomes helpful to mark the functions themselves
FINAL if there is no need to override them.

r=me but I suggest adding some FINAL to any functions we don’t need to
override.


More information about the webkit-reviews mailing list