[webkit-reviews] review granted: [Bug 122362] FramePolicyFunction should be an std::function : [Attachment 213421] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 4 17:38:53 PDT 2013


Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 122362: FramePolicyFunction should be an std::function
https://bugs.webkit.org/show_bug.cgi?id=122362

Attachment 213421: Patch
https://bugs.webkit.org/attachment.cgi?id=213421&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Cute how you made the functions the last argument to match the “block is last
argument” style we use for the corresponding Objective-C feature. Not sure if
that’s the tradition for C++ but it does seem to make the code readable.

I don’t think I’ll ever use a PTMF again!


More information about the webkit-reviews mailing list