[webkit-reviews] review granted: [Bug 122201] Add *CSS* prefix to FontValue to generate toCSSFontValue() : [Attachment 213263] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 122201: Add *CSS* prefix to FontValue to generate toCSSFontValue()
https://bugs.webkit.org/show_bug.cgi?id=122201

Attachment 213263: Patch
https://bugs.webkit.org/attachment.cgi?id=213263&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213263&action=review


> Source/WebCore/css/CSSValue.cpp:182
> +	       return compareCSSValues<CSSFontValue>(*this, other);

Why aren’t we using the checked cast here?

> Source/WebCore/css/CSSValue.cpp:284
> +	   return static_cast<const CSSFontValue*>(this)->customCSSText();

Why aren’t we using the checked cast here?

> Source/WebCore/css/CSSValue.cpp:399
> +	   delete static_cast<CSSFontValue*>(this);

Why aren’t we using the checked cast here?