[webkit-reviews] review granted: [Bug 122329] [Mac] Don't preflight spell checker when calling -setContinuousSpellCheckingEnabled repeatedly : [Attachment 213369] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 122329: [Mac] Don't preflight spell checker when calling
-setContinuousSpellCheckingEnabled repeatedly
https://bugs.webkit.org/show_bug.cgi?id=122329

Attachment 213369: proposed patch
https://bugs.webkit.org/attachment.cgi?id=213369&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213369&action=review


> Source/WebKit/mac/WebView/WebView.mm:-5547
>      if (continuousSpellCheckingEnabled != flag) {
>	   continuousSpellCheckingEnabled = flag;
>	   [[NSUserDefaults standardUserDefaults]
setBool:continuousSpellCheckingEnabled
forKey:WebContinuousSpellCheckingEnabled];
> -    }

I think this would read better as early return than with all the code nested
inside and if statement.