[webkit-reviews] review granted: [Bug 122357] Teach webkitdirs.pm to honor the --64-bit flag : [Attachment 213414] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 4 16:30:42 PDT 2013


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 122357: Teach webkitdirs.pm to honor the --64-bit flag
https://bugs.webkit.org/show_bug.cgi?id=122357

Attachment 213414: Patch
https://bugs.webkit.org/attachment.cgi?id=213414&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213414&action=review


r=me

> Tools/Scripts/webkitdirs.pm:886
> +    return $#matchingIndices > -1;

I think this might be clearer:

return scalar @matchingIndices > 0;

Or:

return scalar @matchingIndices;


More information about the webkit-reviews mailing list