[webkit-reviews] review granted: [Bug 122339] Support for-of syntax : [Attachment 213388] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 122339: Support for-of syntax
https://bugs.webkit.org/show_bug.cgi?id=122339

Attachment 213388: Patch
https://bugs.webkit.org/attachment.cgi?id=213388&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213388&action=review


r=me

Please add a few tests we talked about.

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1791
> +    bool optimizedForinAccess = false;

Please remove this.

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1826
> +    if (optimizedForinAccess)
> +	   generator.popOptimisedForIn();

Please remove this. It's dead in the for-of case.

> Source/JavaScriptCore/runtime/ArrayIteratorPrototype.cpp:81
> -    
> +

Please revert this accidental whitespace change.