[webkit-reviews] review granted: [Bug 122319] WinLauncher needs crash report : [Attachment 213391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 4 13:00:10 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 122319: WinLauncher needs crash report
https://bugs.webkit.org/show_bug.cgi?id=122319

Attachment 213391: Patch
https://bugs.webkit.org/attachment.cgi?id=213391&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213391&action=review


r=me, but please fix the missing namespace on the SHGetFolderPathW call when
you land.

> Tools/WinLauncher/WinLauncher.cpp:418
> +    if (FAILED(SHGetFolderPathW(0, CSIDL_LOCAL_APPDATA | CSIDL_FLAG_CREATE,
0, 0, appDataDirectory)))

::SHGetFolderPathW


More information about the webkit-reviews mailing list