[webkit-reviews] review granted: [Bug 122197] [CSS Shapes] Shape Outside should relayout when set dynamically : [Attachment 213301] Updated patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Bear Travis
<betravis at adobe.com>'s request for review:
Bug 122197: [CSS Shapes] Shape Outside should relayout when set dynamically
https://bugs.webkit.org/show_bug.cgi?id=122197

Attachment 213301: Updated patch
https://bugs.webkit.org/attachment.cgi?id=213301&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213301&action=review


This is unrelated to your current change, but I think we need to consolidate
removeFloatingOrPositionedChildFromBlockLists to avoid calling it twice in the
same style change. Currently there are already two places that could call
removeFloatingOrPositionedChildFromBlockLists in the same style change. Can you
add a bug for it please?

r=me

>
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html:9

> +	   if (document.body)
> +	       document.body.offsetTop;
> +	   else if (document.documentElement)
> +	       document.documentElement.offsetTop;

nit: I think that onload will always have a document.body.

>
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html:1
4
> +	   el.setAttribute('class', 'shape rectangle50');

nit: you can use el.className = "";