[webkit-reviews] review denied: [Bug 122298] Allow misspelling dots to overhang their constituent text by a single pixel : [Attachment 213289] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 4 11:00:06 PDT 2013


Sam Weinig <sam at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 122298: Allow misspelling dots to overhang their constituent text by a
single pixel
https://bugs.webkit.org/show_bug.cgi?id=122298

Attachment 213289: Patch
https://bugs.webkit.org/attachment.cgi?id=213289&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213289&action=review


How does this nudge work for other font sizes / fonts / glyphs in fonts.  This
also needs tests.

> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:165
> +	       width = ceil(width/patternWidth)*patternWidth;

Please put spaces around the  / and *.


More information about the webkit-reviews mailing list