[webkit-reviews] review granted: [Bug 121586] Fix the HTMLSelectElement.prototype.remove() method : [Attachment 213297] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Christophe Dumez <dchris at gmail.com>'s
request for review:
Bug 121586: Fix the HTMLSelectElement.prototype.remove() method
https://bugs.webkit.org/show_bug.cgi?id=121586

Attachment 213297: Patch
https://bugs.webkit.org/attachment.cgi?id=213297&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213297&action=review


Looks fine as long as we fix GTK.

> Source/WebCore/html/HTMLSelectElement.h:63
> +    void removeByIndex(int);

This change broke GTK’s binding: webkit_dom_html_select_element_remove. I guess
we have to fix that.