[webkit-reviews] review granted: [Bug 119479] Inserting a JS generated keyframe animation shouldn't trigger a whole document style recalc : [Attachment 213285] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ralph T <ralpht+bugs at gmail.com>'s
request for review:
Bug 119479: Inserting a JS generated keyframe animation shouldn't trigger a
whole document style recalc
https://bugs.webkit.org/show_bug.cgi?id=119479

Attachment 213285: Patch
https://bugs.webkit.org/attachment.cgi?id=213285&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=213285&action=review


r=me

> Source/WebCore/ChangeLog:9
> +	   https://bugs.webkit.org/show_bug.cgi?id=119479
> +
> +	   Change CSSStyleSheet::didMutateRules to not invalidate all node's
styles when inserting a
> +	   @-webkit-keyframes rule, and to instead insert the rule directly
into the StyleResolver.
> +
> +	   Reviewed by NOBODY (OOPS!).

Reviewed-by line usually goes after the URL, before the descriptive text.

> Source/WebCore/ChangeLog:11
> +	   No new tests (OOPS!).

Some tests for dynamic insertions (and deletions too) would be nice.