[webkit-reviews] review granted: [Bug 122271] [WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute : [Attachment 213254] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 3 12:55:06 PDT 2013

Previous message: [webkit-reviews] review canceled: [Bug 122265] [CSS Regions] Follow-up code style change after bug #121828 All regions have layers : [Attachment 213243] patch
Next message: [webkit-reviews] review granted: [Bug 122272] [WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the OperationsNotDeletable attribute : [Attachment 213255] Patch
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 122271: [WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the
OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122271

Attachment 213254: Patch
https://bugs.webkit.org/attachment.cgi?id=213254&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213254&action=review


> Source/WebCore/dom/Attr.idl:24
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/BeforeLoadEvent.idl:29
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/BeforeUnloadEvent.idl:28
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/CDATASection.idl:21
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/ClientRect.idl:29
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/Comment.idl:21
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/CustomElementConstructor.idl:29
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/DOMError.idl:31
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/DocumentType.idl:22
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/Entity.idl:21
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/EntityReference.idl:21
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/ErrorEvent.idl:34
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/FocusEvent.idl:29
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/MessageChannel.idl:35
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/MutationRecord.idl:33
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/Notation.idl:21
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/PageTransitionEvent.idl:28
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/PopStateEvent.idl:30
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/ProcessingInstruction.idl:23
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/ProgressEvent.idl:29
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/SecurityPolicyViolationEvent.idl:28
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/Touch.idl:29
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/TransitionEvent.idl:29
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/WebKitAnimationEvent.idl:28
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/WebKitTransitionEvent.idl:28
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

More information about the webkit-reviews mailing list