[webkit-reviews] review granted: [Bug 122254] [CSS Shapes] Support the shape-image-threshold property : [Attachment 213250] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 122254: [CSS Shapes] Support the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122254

Attachment 213250: Patch
https://bugs.webkit.org/attachment.cgi?id=213250&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213250&action=review


r=me

> Source/WebCore/rendering/shapes/ShapeInfo.cpp:62
> -	   m_shape = Shape::createShape(shapeValue->image(), 0,
m_shapeLogicalSize, writingMode, margin, padding);
> +	   m_shape = Shape::createShape(shapeValue->image(),
shapeImageThreshold, m_shapeLogicalSize, writingMode, margin, padding);

Maybe Shape::createShape() should ASSERT that shapeImageThreshold is between 0
and 1?