[webkit-reviews] review granted: [Bug 122265] [CSS Regions] Follow-up code style change after bug #121828 All regions have layers : [Attachment 213243] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 3 12:25:36 PDT 2013


Darin Adler <darin at apple.com> has granted Mihai Maerean <mmaerean at adobe.com>'s
request for review:
Bug 122265: [CSS Regions] Follow-up code style change after bug #121828 All
regions have layers
https://bugs.webkit.org/show_bug.cgi?id=122265

Attachment 213243: patch
https://bugs.webkit.org/attachment.cgi?id=213243&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213243&action=review


> Source/WebCore/rendering/RenderMultiColumnSet.cpp:417
> +    // RenderMultiColumnSet derives from RenderRegion, but unlike the CSS
Regions specification, the Multi-Columns CSS
> +    // specification states that the column boxes do not establish new
Stacking Contexts.

Missing comma here after the word "but". I’ll set commit-queue+ anyway, because
we should not hold this all up just for a comma.


More information about the webkit-reviews mailing list