[webkit-reviews] review requested: [Bug 122243] [css-shapes] shape-outside does not properly handle the container and the float having different writing modes : [Attachment 213207] Patch

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 122243: [css-shapes] shape-outside does not properly handle the container
and the float having different writing modes
https://bugs.webkit.org/show_bug.cgi?id=122243

Attachment 213207: Patch
https://bugs.webkit.org/attachment.cgi?id=213207&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213207&action=review


3 small comments below, otherwise looks good to me.


> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:70
> +		   m_leftMarginBoxDelta = segments[0].logicalLeft +
containingBlock->marginStartForChild(m_renderer);

We should use segments.first().logicalLeft here.

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:71
> +		   m_rightMarginBoxDelta =
segments[segments.size()-1].logicalRight -
containingBlock->logicalWidthForChild(m_renderer) -
containingBlock->marginEndForChild(m_renderer);

We should use segments.last().logicalRight here.

>
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-different-wri
ting-modes-expected.html:22
> +</body>

I would put a link to the bug # and the title.