[webkit-reviews] review requested: [Bug 121970] [WK2] Does not remove page from WebProcessProxy's map upon WebProcess termination : [Attachment 213185] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 2 12:34:33 PDT 2013


Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 121970: [WK2] Does not remove page from WebProcessProxy's map upon
WebProcess termination
https://bugs.webkit.org/show_bug.cgi?id=121970

Attachment 213185: Patch
https://bugs.webkit.org/attachment.cgi?id=213185&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
How about something like this? The interaction between m_isClosed and isValid()
seems pretty complex, I cannot see how the page would get unregistered from the
map regardless of the case, though, if the web process has gone away at least
once (it is not just in the not done starting case it turns out).


More information about the webkit-reviews mailing list