[webkit-reviews] review granted: [Bug 122205] FTL: Refactor compileArithDiv and compileArithMod into one function. : [Attachment 213169] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 2 09:37:16 PDT 2013


Darin Adler <darin at apple.com> has granted Nadav Rotem <nrotem at apple.com>'s
request for review:
Bug 122205: FTL: Refactor compileArithDiv and compileArithMod into one
function.
https://bugs.webkit.org/show_bug.cgi?id=122205

Attachment 213169: Patch
https://bugs.webkit.org/attachment.cgi?id=213169&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213169&action=review


> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:783
> +    enum DivOrModKind {Div, Mod};

Formatting error. We use spaces inside the braces.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:787
> +	   bool isDiv = opKind == Div;

Seems like we could say "opKind == Div" at the two sites where this is used.
The boolean doesn’t add significant clarity.


More information about the webkit-reviews mailing list