[webkit-reviews] review denied: [Bug 122210] Remove Qt bots and EWS from trunk. : [Attachment 213160] patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Ádám Kallai
<kadam at inf.u-szeged.hu>'s request for review:
Bug 122210: Remove Qt bots and EWS from trunk.
https://bugs.webkit.org/show_bug.cgi?id=122210

Attachment 213160: patch
https://bugs.webkit.org/attachment.cgi?id=213160&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213160&action=review


>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-770
>> -	    if not platform.startswith("qt"):
> 
> It seems this one is for non-qt slaves. Probably the
self.addStep(KillOldProcesses()) is required for non-qt bots.

good catch. :)

self.addStep(KillOldProcesses()) should run unconditionally. Please fix it.