[webkit-reviews] review granted: [Bug 122178] Variable event stream (for DFG OSR exit) should be explicit about where on the stack a SetLocal put a value : [Attachment 213121] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 122178: Variable event stream (for DFG OSR exit) should be explicit about
where on the stack a SetLocal put a value
https://bugs.webkit.org/show_bug.cgi?id=122178

Attachment 213121: the patch
https://bugs.webkit.org/attachment.cgi?id=213121&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213121&action=review


r=me

> Source/JavaScriptCore/dfg/DFGVariableEvent.h:234
> +	   return static_cast<VirtualRegister>(m_representation.virtualReg);

You can just use constructor syntax here:
VirtualRegister(m_representation.virtualReg).

> Source/JavaScriptCore/dfg/DFGVariableEvent.h:240
> +	   return static_cast<VirtualRegister>(m_representation.virtualReg);

Ditto.

> Source/JavaScriptCore/dfg/DFGVariableEvent.h:246
> +	   return static_cast<VirtualRegister>(m_which.virtualReg);

You can just use constructor syntax here: VirtualRegister(m_which.virtualReg).