[webkit-reviews] review granted: [Bug 122170] FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check. : [Attachment 213117] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Nadav Rotem <nrotem at apple.com>'s
request for review:
Bug 122170: FTL: split overflow checks into non-overflow arithmetic and an
additional call to the overflow intrinsic check.
https://bugs.webkit.org/show_bug.cgi?id=122170

Attachment 213117: Patch
https://bugs.webkit.org/attachment.cgi?id=213117&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213117&action=review


Looks great!

> Source/JavaScriptCore/ChangeLog:36
> +LBB0_1:				   ## %OSR exit continuation for
@24<Int32>
> +					   ## =>This Inner Loop Header: Depth=1

> +    movl  %ecx, %esi
> +    incl  %esi
> +    jo  LBB0_4

I would indent this.