[webkit-reviews] review granted: [Bug 122062] Web Inspector: content view in back/forward list multiple times won't restore earlier positions : [Attachment 212954] Take 2

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 122062: Web Inspector: content view in back/forward list multiple times
won't restore earlier positions
https://bugs.webkit.org/show_bug.cgi?id=122062

Attachment 212954: Take 2
https://bugs.webkit.org/attachment.cgi?id=212954&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212954&action=review


> Source/WebInspectorUI/ChangeLog:60
> +	   Need a short description (OOPS!).
> +	   Need the bug URL (OOPS!).

OOPS.

> Source/WebInspectorUI/UserInterface/BackForwardEntry.js:37
> +WebInspector.BackForwardEntry.prototype = {
> +    constructor: WebInspector.BackForwardEntry,

Even if it isn't useful now, this should still inherit from
WebInspector.Object.

> Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js:264
> +	   var cookie = { lineNumber: positionToReveal.lineNumber,
columnNumber: positionToReveal.columnNumber};

Nit, space after { should be removed.