[webkit-reviews] review requested: [Bug 122015] [ATK] Expose aria-invalid as a text attribute (not object attribute) : [Attachment 213096] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 122015: [ATK] Expose aria-invalid as a text attribute (not object
attribute)
https://bugs.webkit.org/show_bug.cgi?id=122015

Attachment 213096: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=213096&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #12)
> [...]
> > Thus, I think I will update the patch moving that logic from the ATK
> > wrapper into AccessibilityObject::invalidStatus(). The aria-invalid
> > test should keep passing fine for the Mac as it is, although I will
> > probably add a new element with a not specified value to make sure
> > we return "true" in that case as well.
> 
> Sounds good

Done. See the patch attached. I changed the test to cover all the cases, but it
should work on the Mac too.