[webkit-reviews] review granted: [Bug 122151] Web Inspector: evaluate and show a popover for selected text in JS source when paused : [Attachment 213068] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 122151: Web Inspector: evaluate and show a popover for selected text in JS
source when paused
https://bugs.webkit.org/show_bug.cgi?id=122151

Attachment 213068: Patch
https://bugs.webkit.org/attachment.cgi?id=213068&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213068&action=review


r=me

> Source/WebInspectorUI/UserInterface/CodeMirrorTokenTrackingController.js:168
> +	       if (highlightedRange.from.line === range.start.line &&
> +		   highlightedRange.from.ch === range.start.ch &&
> +		   highlightedRange.to.line === range.end.line &&
> +		   highlightedRange.to.ch === range.end.ch)

This could use WebInspector.compareCodeMirrorPositions:

    if (WebInspector.compareCodeMirrorPositions(highlightedRange.from,
range.start) === 0 &&
	WebInspector.compareCodeMirrorPositions(highlightedRange.to, range.end)
=== 0)

But what you have is just fine!