[webkit-reviews] review denied: [Bug 122155] [WK2] Font hinting should be disabled : [Attachment 213074] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 09:56:07 PDT 2013


Darin Adler <darin at apple.com> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 122155: [WK2] Font hinting should be disabled
https://bugs.webkit.org/show_bug.cgi?id=122155

Attachment 213074: Patch
https://bugs.webkit.org/attachment.cgi?id=213074&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I don’t think this makes sense. We don’t want to add a global to Font when no
port is looking to make this dynamic at runtime. Especially if this feature is
for the sunsetting Qt port. Can you just put this unconditionally in
FontPlatformDataQt.cpp? Or do this in a Qt fork since we’re near the end of Qt
in the main WebKit tree.


More information about the webkit-reviews mailing list