[webkit-reviews] review granted: [Bug 122000] [GStreamer] Support "chapter" text tracks : [Attachment 213086] Patch for landing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 08:57:27 PDT 2013


Eric Carlson <eric.carlson at apple.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 122000: [GStreamer] Support "chapter" text tracks
https://bugs.webkit.org/show_bug.cgi?id=122000

Attachment 213086: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=213086&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213086&action=review


>
Source/WebCore/platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStrea
mer.h:36
> +class InbandMetadataTextTrackPrivateGStreamer : public
InbandTextTrackPrivate {

You forgot to mark this FINAL, but it is OK to fix this in a follow-up.


More information about the webkit-reviews mailing list